fix: missed some followups with respect to error injection#7538
Merged
davidporter-id-au merged 1 commit intocadence-workflow:masterfrom Dec 15, 2025
Merged
Conversation
Signed-off-by: David Porter <david.porter@uber.com>
davidporter-id-au
requested review from
3vilhamster,
Shaddoll,
demirkayaender,
dkrotx,
jakobht,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
c-warren
approved these changes
Dec 15, 2025
AndreasHolt
pushed a commit
to AndreasHolt/cadence
that referenced
this pull request
Dec 16, 2025
…orkflow#7538) <!-- Describe what has changed in this PR --> **What changed?** I missed a few of Chris' suggestions in an cadence-workflow#7532, so addressing them here. - adds a missing test - corrects a comment <!-- Tell your future self why have you made these changes --> **Why?** <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** <!-- Is it notable for release? e.g. schema updates, configuration or data migration required? If so, please mention it, and also update CHANGELOG.md --> **Release notes** <!-- Is there any documentation updates should be made for config, https://cadenceworkflow.io/docs/operation-guide/setup/ ? If so, please open an PR in https://github.com/cadence-workflow/cadence-docs --> **Documentation Changes** Signed-off-by: David Porter <david.porter@uber.com> Signed-off-by: Andreas Holt <6665487+AndreasHolt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
I missed a few of Chris' suggestions in an #7532, so addressing them here.
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes