fix(shard-distributor): remove usage of context from Start in canary#7541
Merged
arzonus merged 1 commit intocadence-workflow:masterfrom Dec 17, 2025
Merged
fix(shard-distributor): remove usage of context from Start in canary#7541arzonus merged 1 commit intocadence-workflow:masterfrom
arzonus merged 1 commit intocadence-workflow:masterfrom
Conversation
arzonus
requested review from
3vilhamster,
Shaddoll,
davidporter-id-au,
demirkayaender,
dkrotx,
jakobht,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
Contributor
|
I think we should find another way to handle the context more than not propagating it. But for now, since it is canary and since it is affecting sd, I am good with this solution |
eleonoradgr
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
context.ContextfromStartmethod in processor/processorephemeral.ShardProcessoris not propagated toprocessmethodWhy?
context.Contextcan be directly propagated from an external RPC call, limiting the lifetime of aShardProcessorto the RPC call's lifetime.Stopfunction is already responsible for an appropriate stopping ofShardProcessor.How did you test it?