refactor: Update matching executor configs#7547
Merged
gazi-yestemirova merged 8 commits intocadence-workflow:masterfrom Dec 18, 2025
Merged
refactor: Update matching executor configs#7547gazi-yestemirova merged 8 commits intocadence-workflow:masterfrom
gazi-yestemirova merged 8 commits intocadence-workflow:masterfrom
Conversation
gazi-yestemirova
requested review from
3vilhamster,
Shaddoll,
davidporter-id-au,
demirkayaender,
dkrotx,
jakobht,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
gazi-yestemirova
changed the title
service/matching/handler/engine.go
Outdated
| } | ||
| if reportTTL == 0 { | ||
| reportTTL = 1 * time.Minute | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I don't have a strong opinion on this, if you feel like this is redundant I can remove it @eleonoradgr
gazi-yestemirova
force-pushed
the
update_matching_configs
branch
from
9bbfaab to
ff37243
Compare
jakobht
reviewed
Dec 17, 2025
service/matching/handler/engine.go
Outdated
Comment on lines
+196
to
+198
| if len(cfg.Namespaces) > 0 { | ||
| reportTTL = cfg.Namespaces[0].TTLReport | ||
| } |
Member
There was a problem hiding this comment.
I think we should log fatal here if there are more than one namespace define
Contributor
Author
There was a problem hiding this comment.
updated with the logs
Signed-off-by: Gaziza Yestemirova <gaziza@uber.com>
Signed-off-by: Gaziza Yestemirova <gaziza@uber.com>
Signed-off-by: Gaziza Yestemirova <gaziza@uber.com>
eleonoradgr
approved these changes
Dec 18, 2025
Signed-off-by: Gaziza Yestemirova <gaziza@uber.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Extracted the shard distributor executor client configuration for the matching service to config files instead of using hardcoded values.
Why?
This enables different environments to configure shard distributor settings without code changes.
How did you test it?
unit tests & local testing
Potential risks
Release notes
Documentation Changes