fix: enforce TaskListActivitiesPerSecond in matching#7575
Merged
timl3136 merged 1 commit intocadence-workflow:masterfrom Jan 7, 2026
Merged
fix: enforce TaskListActivitiesPerSecond in matching#7575timl3136 merged 1 commit intocadence-workflow:masterfrom
timl3136 merged 1 commit intocadence-workflow:masterfrom
Conversation
Signed-off-by: Tim Li <ltim@uber.com>
timl3136
requested review from
3vilhamster,
Shaddoll,
davidporter-id-au,
demirkayaender,
dkrotx,
jakobht,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
timl3136
changed the title
Shaddoll
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Added rate limiting to directly dispatched activities. Modified
OfferOrTimeout()inservice/matching/tasklist/matcher.goto check rate limits before dispatching tasks, matching the behavior of the normalOffer()method.Why?
Activities dispatched via
history.maxActivityCountDispatchByDomainwere skipping the TaskList rate limiter entirely. This meant theTaskListActivitiesPerSecondconfig only worked for normal activities but not for directly dispatched ones.How did you test it?
unit tests
Potential risks
Release notes
Documentation Changes