refactor(matching): rename some matching-engine functions#7591
Merged
dkrotx merged 1 commit intocadence-workflow:masterfrom Jan 14, 2026
Merged
refactor(matching): rename some matching-engine functions#7591dkrotx merged 1 commit intocadence-workflow:masterfrom
dkrotx merged 1 commit intocadence-workflow:masterfrom
Conversation
dkrotx
requested review from
3vilhamster,
Shaddoll,
davidporter-id-au,
demirkayaender,
jakobht,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
dkrotx
force-pushed
the
rename-engine-funcs
branch
from
6fc5d99 to
21ad3bf
Compare
dkrotx
changed the title
These names are more obvious and correspond to what functions are doing. Signed-off-by: Jan Kisel <dkrot@uber.com>
dkrotx
force-pushed
the
rename-engine-funcs
branch
from
21ad3bf to
33e2662
Compare
eleonoradgr
approved these changes
Jan 14, 2026
Scanf-s
pushed a commit
to Scanf-s/cadence
that referenced
this pull request
Jan 15, 2026
…rkflow#7591) These names are more obvious and correspond to what functions are doing. <!-- Describe what has changed in this PR --> **What changed?** Just renaming functions to make them move obvious while read <!-- Tell your future self why have you made these changes --> **Why?** Matching engine code is already complex, let's simplify it by such small renamings. <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** <!-- Is it notable for release? e.g. schema updates, configuration or data migration required? If so, please mention it, and also update CHANGELOG.md --> **Release notes** <!-- Is there any documentation updates should be made for config, https://cadenceworkflow.io/docs/operation-guide/setup/ ? If so, please open an PR in https://github.com/cadence-workflow/cadence-docs --> **Documentation Changes** Signed-off-by: Jan Kisel <dkrot@uber.com> Signed-off-by: Scanf-s <sullung2yo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These names are more obvious and correspond to what functions are doing.
What changed?
Just renaming functions to make them move obvious while read
Why?
Matching engine code is already complex, let's simplify it by such small renamings.
How did you test it?
Potential risks
Release notes
Documentation Changes