refactor: remove time generation from sql db layer#7631
Merged
natemort merged 1 commit intocadence-workflow:masterfrom Jan 23, 2026
Merged
refactor: remove time generation from sql db layer#7631natemort merged 1 commit intocadence-workflow:masterfrom
natemort merged 1 commit intocadence-workflow:masterfrom
Conversation
…meStamp Signed-off-by: Stanislav Bychkov <stanislb@netapp.com>
ribaraka
requested review from
3vilhamster,
Shaddoll,
davidporter-id-au,
demirkayaender,
dkrotx,
jakobht,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
bowenxia
approved these changes
Jan 23, 2026
Member
bowenxia
left a comment
bowenxia
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Replaced time.Now() in sql_history/task stores with request.CurrentTime
Why?
I missed a couple of time.Now() calls still living in the sql store layer; we should keep time generation out of low level persistence due to #6610 .
How did you test it?
Unit tests
Potential risks
Release notes
Documentation Changes