Skip to content

chore: set ReplicationTaskProcessorStartWait default to 0#7701

Merged
fimanishi merged 1 commit intocadence-workflow:masterfrom
fimanishi:set-ReplicationTaskProcessorStartWait-to-0s-by-default
Feb 13, 2026
Merged

chore: set ReplicationTaskProcessorStartWait default to 0#7701
fimanishi merged 1 commit intocadence-workflow:masterfrom
fimanishi:set-ReplicationTaskProcessorStartWait-to-0s-by-default

Conversation

@fimanishi
Copy link
Member

@fimanishi fimanishi commented Feb 12, 2026

What changed?
Set the default value for ReplicationTaskProcessorStartWait to zero.

Why?
We introduced the ReplicationTaskProcessorStartWait to protect the standby cluster and its database. That came with the downside of having slower replication. We now have improved Cadence and database utilization, and removing this delay was harmless to the server. By removing this delay, we've reduced the replication lag by 80%.

How did you test it?
This has been tested in our deployments.

Potential risks
This could cause the server or the databases to run hotter. If that is the case, increase the delay value. Previous default was set to 5s.

Release notes
ReplicationTaskProcessorStartWait default value was changed to 0, essentially disabling the replication task processor wait. If you see any issues, increase the wait value. Previous default value was set to 5s.

Documentation Changes


Reviewer Validation

PR Description Quality (check these before reviewing code):

  • "What changed" provides a clear 1-2 line summary
    • Project Issue is linked
  • "Why" explains the full motivation with sufficient context
  • Testing is documented:
    • Unit test commands are included (with exact go test invocation)
    • Integration test setup/commands included (if integration tests were run)
    • Canary testing details included (if canary was mentioned)
  • Potential risks section is thoughtfully filled out (or legitimately N/A)
  • Release notes included if this completes a user-facing feature
  • Documentation needs are addressed (or noted if uncertain)

Signed-off-by: fimanishi <fimanishi@gmail.com>
@gitar-bot
Copy link

gitar-bot bot commented Feb 12, 2026

Code Review ✅ Approved

Clean configuration change that sets ReplicationTaskProcessorStartWait default from 5s to 0. Both the documentation comment and the actual default value are updated consistently, matching the pattern of adjacent properties.

Rules ❌ No requirements met

Repository Rules

PR Description Quality Standards: Add specific test details to **[How did you test it?]** section (e.g., which deployment, metrics observed, test duration). Address **[Documentation Changes]** section by marking N/A with reasoning or specifying documentation needs for this configuration change.
Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@fimanishi fimanishi merged commit 2957961 into cadence-workflow:master Feb 13, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants