Update to latest bootstrapper.#6
Update to latest bootstrapper.#6nikhilagrawaldotnet wants to merge 1 commit intocake-build:developfrom nikhilagrawaldotnet:develop
Conversation
|
Hey. old: -target=foo tx |
nils-a
left a comment
There was a problem hiding this comment.
@nikhilagrawaldotnet When I try this version I get the following errors:
[13:54:00]At C:\TeamCity\buildAgent\temp\buildTmp\powershell3334180761526035403.ps1:8 char:27
[13:54:00]+ [bool]$ShowDescription = false,
[13:54:00]+ ~
[13:54:00]Missing ')' in function parameter list.
[13:54:00]At C:\TeamCity\buildAgent\temp\buildTmp\powershell3334180761526035403.ps1:8 char:35
[13:54:00]+ [bool]$ShowDescription = false,
[13:54:00]+ ~
[13:54:00]Missing argument in parameter list.
[13:54:00]At C:\TeamCity\buildAgent\temp\buildTmp\powershell3334180761526035403.ps1:10 char:26
[13:54:00]+ [bool]$DryRun = false,
[13:54:00]+ ~
[13:54:00]Missing argument in parameter list.
[13:54:00]At C:\TeamCity\buildAgent\temp\buildTmp\powershell3334180761526035403.ps1:15 char:1
[13:54:00]+ )
[13:54:00]+ ~
[13:54:00]Unexpected token ')' in expression or statement.
[13:54:00] + CategoryInfo : ParserError: (:) [], ParentContainsErrorRecordException
[13:54:00] + FullyQualifiedErrorId : MissingExpressionAfterToken
[13:54:00]
[13:54:00]Process exited with code 1
I added two suggestions that fixed the error for me.
| [string]$Configuration = "%mr.Cake.configuration%", | ||
| [ValidateSet("Quiet", "Minimal", "Normal", "Verbose", "Diagnostic")] | ||
| [string]$Verbosity = "%mr.Cake.verbosity%", | ||
| [bool]$ShowDescription = %mr.Cake.showdescription%, |
There was a problem hiding this comment.
This line raises an error on usage.
| [bool]$ShowDescription = %mr.Cake.showdescription%, | |
| [bool]$ShowDescription = $%mr.Cake.showdescription%, |
| [string]$Verbosity = "%mr.Cake.verbosity%", | ||
| [bool]$ShowDescription = %mr.Cake.showdescription%, | ||
| [Alias("WhatIf", "Noop")] | ||
| [bool]$DryRun = %mr.Cake.dryrun%, |
There was a problem hiding this comment.
this line raises an error on usage.
| [bool]$DryRun = %mr.Cake.dryrun%, | |
| [bool]$DryRun = $%mr.Cake.dryrun%, |
|
Also, it seems that you simply updated to the latest bootstrapper without modifying it. This will break existing builds, as the the The old script contained: $repositoryPath = "%teamcity.build.workingDir%";
$toolsPath = Join-Path $repositoryPath "tools";and worked its way from there. The new one contains: $TOOLS_DIR = Join-Path $PSScriptRoot "tools"This folder (i.e. |
This PR brings MR upto speed with latest bootstrapper. Additional params have been added as separate controls with default values.
@gep13 Resolved issues #4 #2 #5