(#728) update omnisharp on every update of cake.bakery#729
Merged
gep13 merged 1 commit intocake-build:hotfix/2.1.1from Oct 11, 2022
Merged
(#728) update omnisharp on every update of cake.bakery#729gep13 merged 1 commit intocake-build:hotfix/2.1.1from
gep13 merged 1 commit intocake-build:hotfix/2.1.1from
Conversation
bjorkstromm
reviewed
Oct 11, 2022
bjorkstromm
previously requested changes
Oct 11, 2022
Member
bjorkstromm
left a comment
bjorkstromm
left a comment
There was a problem hiding this comment.
One minor... How do I test it? Do we publish VSIX on PR build?
Member
Author
|
checkout, We should probably look into uploading the VSIX as an artifact, or publishing previews to https://www.vsixgallery.com (though I'm not sure it hosts vscode VSIX) |
nils-a
force-pushed
the
feature/GH-728
branch
from
1601559 to
5d0cdd4
Compare
gep13
dismissed
bjorkstromm’s stale review
Suggested changes have been implemented.
Member
|
@nils-a thank you very much for getting this fixed up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #728