use ArgumentNullException.ThrowIfNull#4572
Merged
devlead merged 2 commits intocake-build:developfrom Oct 7, 2025
SimonCropp:use-ArgumentNullException.ThrowIfNull
Merged
use ArgumentNullException.ThrowIfNull#4572devlead merged 2 commits intocake-build:developfrom SimonCropp:use-ArgumentNullException.ThrowIfNull
devlead merged 2 commits intocake-build:developfrom
SimonCropp:use-ArgumentNullException.ThrowIfNull
Conversation
devlead
requested changes
Aug 27, 2025
Member
There was a problem hiding this comment.
Request Changes
Technical Review: ArgumentNullException.ThrowIfNull() is technically correct, this scope requires careful review.
Process Issues:
- ❌ Missing Issue Link: This PR must be linked to an issue describing the modernization effort
- ❌ Insufficient Description: PR description should explain the scope and benefits
- ❌ CI Status: Build failures detected - must fix before review
Recommendation:
- Fix the build failures first
- Create an issue describing the .NET modernization effort
- Add comprehensive description explaining the changes
- Ensure all tests pass
Update assertion parameter name from "namespace" to "@namespace" to match actual parameter
This was referenced Nov 11, 2025
This was referenced Nov 11, 2025
This was referenced Nov 12, 2025
This was referenced Nov 24, 2025
This was referenced Dec 1, 2025
This was referenced Dec 11, 2025
This was referenced Jan 19, 2026
This was referenced Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.