Skip to content

GH4720: Use non-boolean self-contained arguments for dotnet publish. #4722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devlead merged 1 commit into from
Feb 12, 2026
Merged

GH4720: Use non-boolean self-contained arguments for dotnet publish. #4722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Cake.Common.Tests/Unit/Tools/DotNet/Publish/DotNetPublisherTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ public void Should_Add_Settings()
var result = fixture.Run();

// Then
Assert.Equal("publish --output \"/Working/artifacts\" --runtime runtime1 --framework dnxcore50 --configuration Release --version-suffix rc1 --no-build --no-dependencies --no-restore --nologo --force --self-contained true --source \"https://api.nuget.org/v3/index.json\" --verbosity minimal", result.Args);
Assert.Equal("publish --output \"/Working/artifacts\" --runtime runtime1 --framework dnxcore50 --configuration Release --version-suffix rc1 --no-build --no-dependencies --no-restore --nologo --force --self-contained --source \"https://api.nuget.org/v3/index.json\" --verbosity minimal", result.Args);
}

[Fact]
Expand All @@ -147,7 +147,7 @@ public void Should_Add_SelfContained_False_Settings()
var result = fixture.Run();

// Then
Assert.Equal("publish --output \"/Working/artifacts\" --runtime runtime1 --framework dnxcore50 --configuration Release --version-suffix rc1 --no-dependencies --no-restore --force --self-contained false --source \"https://api.nuget.org/v3/index.json\" --verbosity minimal", result.Args);
Assert.Equal("publish --output \"/Working/artifacts\" --runtime runtime1 --framework dnxcore50 --configuration Release --version-suffix rc1 --no-dependencies --no-restore --force --no-self-contained --source \"https://api.nuget.org/v3/index.json\" --verbosity minimal", result.Args);
}

[Fact]
Expand Down
5 changes: 2 additions & 3 deletions src/Cake.Common/Tools/DotNet/Publish/DotNetPublisher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,14 +125,13 @@ private ProcessArgumentBuilder GetArguments(string path, DotNetPublishSettings s
// Self contained
if (settings.SelfContained.HasValue)
{
builder.Append("--self-contained");
if (settings.SelfContained.Value)
{
builder.Append("true");
builder.Append("--self-contained");
}
else
{
builder.Append("false");
builder.Append("--no-self-contained");
}
}

Expand Down
Loading