Skip to content

Update gitattributes file#133

Merged
markstory merged 4 commits intocakephp:masterfrom
bcrowe:attributes
Jul 10, 2015
Merged

Update gitattributes file#133
markstory merged 4 commits intocakephp:masterfrom
bcrowe:attributes

Conversation

@bcrowe
Copy link
Copy Markdown
Contributor

@bcrowe bcrowe commented Jul 9, 2015

We don't need any of this included during Composer installs, etc.

.gitattributes Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can just ignore tests/. In core we want the fixtures to be available to users for development hence we ignore these 2 dirs separately.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need fixtures is dist installs either.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non dist installs which pull in cake repo history are pretty slow and often timeout. That was a major annoyance during plugin development and testing. Keeping the fixtures in core's dist install allows using the dist install for development too and speed up testing.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I meant bake's fixtures shouldn't be included in dist installs of bake.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, i misunderstood your comment. Reading it again i realize you were just agreeing with my comment :)

@markstory markstory added this to the 1.0.11 milestone Jul 9, 2015
@bcrowe
Copy link
Copy Markdown
Contributor Author

bcrowe commented Jul 10, 2015

Updated to export-ignore entire the tests directory.

markstory added a commit that referenced this pull request Jul 10, 2015
@markstory markstory merged commit fde39f6 into cakephp:master Jul 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants