Correct plugin generation for vendored plugins.#138
Merged
Conversation
Add additional template variables and templates to handle vendor plugins correctly. Refs cakephp/cakephp#7062
Contributor
|
@markstory didn't tested it yet but it looks strange to me that the |
Member
Author
|
@antograssiot I missed that as its not in the test cases. I'll get that updated tonight. |
Use the correctly slashed namespace in the app's composer.json. Refs #7062
Member
Author
|
@antograssiot Fixed 😄 |
Contributor
|
Looks good to me 👍 |
lorenzo
added a commit
that referenced
this pull request
Jul 26, 2015
Correct plugin generation for vendored plugins.
Member
|
Great job! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add additional template variables and templates to handle vendor plugins correctly.
Refs cakephp/cakephp#7062