Insert fields in PhpDoc of the Entity#147
Closed
GerardSmit wants to merge 1 commit intocakephp:masterfrom
GerardSmit:master
Closed
Insert fields in PhpDoc of the Entity#147GerardSmit wants to merge 1 commit intocakephp:masterfrom GerardSmit:master
GerardSmit wants to merge 1 commit intocakephp:masterfrom
GerardSmit:master
Conversation
Member
There was a problem hiding this comment.
There are tests that check the generated files. Those will need to be updated. The travis.ci build has the details of which comparison files need changes.
Member
|
Any chance this could be updated so the tests pass? |
Contributor
|
I can take care of this whole thing in case @gsmit1996 isn't going to / cannot work on this further? I've started with entity property hints this some time ago, but put them on hold because I couldn't find a proper way to detect the possible datatypes for custom database types, and I was hell-bent on having either everything typed, or nothing. |
Member
|
@ndm2 That would be great. |
ndm2
pushed a commit
to ndm2/bake
that referenced
this pull request
Sep 4, 2015
Member
|
Closing as there was another pull request taking care of this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.