Conversation
With configure read calls, which are initialized when calling the shell if not already overridden. Also change the method used for determining table options to return an array for easier testing
These are the files currently used from a src install when running tests
Also change the namespace for expectations to be something bake specific. Refactor the ClassOptionsForTable tests to test the returned array, not the expected calls to cli-out
AD7six
force-pushed
the
allow-dist-install-tests
branch
from
28ff960 to
f8b1cfc
Compare
This shouldn't have been committed
tests/bootstrap.php
Outdated
Member
Author
There was a problem hiding this comment.
They could, and infact were earlier but I fale at simple decisions. Do we have a preference? The core doesn't use autoload-dev which is what swung me in this direction.
Member
There was a problem hiding this comment.
We should probably use autoload-dev in the core too. I can change that up :)
Member
|
Does this mean we can remove some of the TestApp stubs from cakephp/cakephp too? |
Member
Author
Probably - I don't know (haven't checked) if anything else is referring to them. I can delete them and see what fails though. |
TESTS isn't used in the core anywhere
there _aren't_ any core bake tasks any more
Member
Author
|
Depends on cakephp/cakephp#5507 |
Member
|
Outstanding @AD7six 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes allow a dist install.