Fixed "all" Task to allow plugin baking.#17
Merged
Conversation
Member
|
Looks good to me. Test failures are likely to be unrelated. |
Closed
Member
There was a problem hiding this comment.
I don't think associations should be serialized
Contributor
Author
|
Will fix that the next days, what you would recommend instead in the task? Not baking the compact but only the main stuff? |
Contributor
Author
|
Fixed the serialize to only use the main model. |
Member
|
Thanks! |
lorenzo
added a commit
that referenced
this pull request
Jan 5, 2015
Fixed "all" Task to allow plugin baking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling "bake" directly in the Tasks skips the $this->_getName(); function call, which separates Plugin from Name. Fix is to call main(); instead of bake();.