Conversation
While it is possible to add rules for multi-column unique keys, doing so would require changing the template data, which will likely break userland templates. For that reason, I'd rather not add support for multi-column unique keys at this point in time. Refs #182
Member
|
Good job! |
Member
|
I'll see why php 7 is not happy in travis |
|
Thanks! Out of interest: When 3.2 or 4.x hits multi column unique key constraint should be added? |
Member
Author
|
@jhli We'd have to break compatibility with previous versions of bake. That doesn't have to be timed with a change in a CakePHP version necessarily. |
|
Okay, I did open that ticket in case I get to bake improvements early next year it's not forgotten. |
markstory
added a commit
that referenced
this pull request
Dec 12, 2015
Generate isUnique rules for single column unique key indexes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While it is possible to add rules for multi-column unique keys, doing so would require changing the template data, which will likely break userland templates. For that reason, I'd rather not add support for multi-column unique keys at this point in time.
Refs #182