Skip to content

Baked tables use App\Model\Entity\EntityName;#33

Merged
markstory merged 1 commit intocakephp:masterfrom
sitedyno:table-use-app-entity
Jan 29, 2015
Merged

Baked tables use App\Model\Entity\EntityName;#33
markstory merged 1 commit intocakephp:masterfrom
sitedyno:table-use-app-entity

Conversation

@sitedyno
Copy link
Copy Markdown
Contributor

Would close #32

Please let me know if I need to change/add etc.

:)

@jadb
Copy link
Copy Markdown
Contributor

jadb commented Jan 28, 2015

👍

@sitedyno
Copy link
Copy Markdown
Contributor Author

Working on the tests.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put this at the top of the list?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proper output for testBakeTableWithPlugin

namespace ModelTest\Model\Table;       

use Cake\ORM\Query;                    
use Cake\ORM\RulesChecker;             
use Cake\ORM\Table;                    
use Cake\Validation\Validator;         
use ModelTest\Model\Entity\BakeArticle;

@sitedyno
Copy link
Copy Markdown
Contributor Author

The test will fail with it at the top as well with the plugin test. Sort them in the template using php?

@josegonzalez
Copy link
Copy Markdown
Member

a+ to sorting :)

@jadb jadb added this to the 1.0.0 milestone Jan 28, 2015
markstory added a commit that referenced this pull request Jan 29, 2015
Baked tables use App\Model\Entity\EntityName;
@markstory markstory merged commit c31e157 into cakephp:master Jan 29, 2015
@markstory
Copy link
Copy Markdown
Member

Thanks @sitedyno

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFC Should bake add use statement to Table for its Entity?

5 participants