Skip to content

fix issuse #37 #38

Merged
markstory merged 1 commit intocakephp:masterfrom
zoghal:path-namespace
Feb 10, 2015
Merged

fix issuse #37 #38
markstory merged 1 commit intocakephp:masterfrom
zoghal:path-namespace

Conversation

@zoghal
Copy link
Copy Markdown
Contributor

@zoghal zoghal commented Feb 9, 2015

fix issuse #37

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in eb9ff7d

@antograssiot
Copy link
Copy Markdown
Contributor

not related but could you also update the composer.json like this so tests passes :

"cakephp/cakephp-codesniffer": "dev-master"

I thought the 2.x tag existed at some time...

@markstory markstory added this to the 1.0.0 milestone Feb 10, 2015
@markstory
Copy link
Copy Markdown
Member

@antograssiot No we never did make that tag. I'll add one now for 2.0.0 😄

markstory added a commit that referenced this pull request Feb 10, 2015
@markstory markstory merged commit ad36ef5 into cakephp:master Feb 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants