Conversation
Codecov Report
@@ Coverage Diff @@
## master #383 +/- ##
=========================================
Coverage 92.19% 92.19%
Complexity 672 672
=========================================
Files 25 25
Lines 2205 2205
=========================================
Hits 2033 2033
Misses 172 172
Continue to review full report at Codecov.
|
|
And I already explained to you why maintaining the same signature is necessary to avoid PHP from complaining about signature mismatch, in an existing userland class which extends ModelTask and has overridden this method. Hopefully @markstory or someone else can explain the same to you again. |
|
I think you are a bit pedantic here on the bc issue which is highly theoretical. |
|
I adjusted to code to ahere to the BC issue (which is really not that big of deal IMO on that require-dev plugin). |
Reverts #382
as I explained already to @ADmad in the comment to the original and valid change to add the typehint, the internal code expects the array, thus this revert here was invalid and a bad idea.
BC has nothing to do with this :)
See if (in_array($fieldName, $primaryKey)) { usage.