Conversation
src/Shell/Task/ModelTask.php
Outdated
| ); | ||
|
|
||
| return $this->_stop(); | ||
| $this->_stop(); |
There was a problem hiding this comment.
You might need this return for when stop is mocked. You could also use abort() instead.
Codecov Report
@@ Coverage Diff @@
## master #387 +/- ##
============================================
+ Coverage 92.19% 92.37% +0.17%
Complexity 672 672
============================================
Files 25 25
Lines 2205 2165 -40
============================================
- Hits 2033 2000 -33
+ Misses 172 165 -7
Continue to review full report at Codecov.
|
|
@ondrejmirtes Is there a better way to deal with this error other than just ignoring it? The issue is caused by use of @property tag within description text. |
|
@ADmad Your problem is not unique, I encountered it in at least three other places. We'll try to ignore phpDocs in the middle of text descriptions, but for now, try to construct as specific regex as possible to ignore it (so that you don't ignore other valid errors). |
|
This is good to go. |
| ); | ||
|
|
||
| return $this->_stop(); | ||
| } |
There was a problem hiding this comment.
Connections need to implement schemaCollection() to be used with bake.
and continue to use $db->schemaCollection(); :)
| $this->err('Your database does not have any tables.'); | ||
|
|
||
| return $this->_stop(); | ||
| $this->abort('Your database does not have any tables.'); |
6 participants
No description provided.