Using \Cake\Http\ServerRequest|Response instead of \Cake\Network\*#399
Merged
markstory merged 2 commits intocakephp:masterfrom Dec 26, 2017
gotoeveryone:fix/celltest-request-response
Merged
Using \Cake\Http\ServerRequest|Response instead of \Cake\Network\*#399markstory merged 2 commits intocakephp:masterfrom gotoeveryone:fix/celltest-request-response
markstory merged 2 commits intocakephp:masterfrom
gotoeveryone:fix/celltest-request-response
Conversation
stickler-ci
reviewed
Dec 26, 2017
Codecov Report
@@ Coverage Diff @@
## master #399 +/- ##
=========================================
Coverage 92.41% 92.41%
Complexity 676 676
=========================================
Files 25 25
Lines 2176 2176
=========================================
Hits 2011 2011
Misses 165 165
Continue to review full report at Codecov.
|
Member
|
Looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
baketask is using the following.\Cake\Network\Request\Cake\Network\ResponseChanged it to use the following.
\Cake\Http\ServerRequest\Cake\Http\Response