Skip to content

Using \Cake\Http\ServerRequest|Response instead of \Cake\Network\*#399

Merged
markstory merged 2 commits intocakephp:masterfrom
gotoeveryone:fix/celltest-request-response
Dec 26, 2017
Merged

Using \Cake\Http\ServerRequest|Response instead of \Cake\Network\*#399
markstory merged 2 commits intocakephp:masterfrom
gotoeveryone:fix/celltest-request-response

Conversation

@gotoeveryone
Copy link
Copy Markdown
Contributor

bake task is using the following.

  • \Cake\Network\Request
  • \Cake\Network\Response

Changed it to use the following.

  • \Cake\Http\ServerRequest
  • \Cake\Http\Response

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 26, 2017

Codecov Report

Merging #399 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #399   +/-   ##
=========================================
  Coverage     92.41%   92.41%           
  Complexity      676      676           
=========================================
  Files            25       25           
  Lines          2176     2176           
=========================================
  Hits           2011     2011           
  Misses          165      165
Impacted Files Coverage Δ Complexity Δ
src/Shell/Task/BakeTemplateTask.php 100% <ø> (ø) 6 <0> (ø) ⬇️
src/Shell/Task/TestTask.php 95.51% <100%> (ø) 89 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d339c79...17547ae. Read the comment docs.

@dereuromark
Copy link
Copy Markdown
Member

Looks good.

@markstory markstory added this to the 1.5.x milestone Dec 26, 2017
@markstory markstory merged commit c849ffc into cakephp:master Dec 26, 2017
@gotoeveryone gotoeveryone deleted the fix/celltest-request-response branch May 8, 2018 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants