Add support for baking a Command Class#449
Merged
markstory merged 2 commits intocakephp:masterfrom May 26, 2018
Merged
Conversation
stickler-ci
reviewed
May 25, 2018
src/Shell/Task/TestTask.php
Outdated
| } | ||
|
|
||
| if ($type !== 'Controller') { | ||
| if ($type !== 'Controller' && $type !== 'Command' ) { |
There was a problem hiding this comment.
Expected 0 spaces before closing bracket; 1 found
| } | ||
|
|
||
|
|
||
| /** |
There was a problem hiding this comment.
Found more than a single empty line between content
Codecov Report
@@ Coverage Diff @@
## master #449 +/- ##
============================================
+ Coverage 94.25% 94.27% +0.02%
- Complexity 685 689 +4
============================================
Files 26 27 +1
Lines 2192 2200 +8
============================================
+ Hits 2066 2074 +8
Misses 126 126
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it possible to bake a Command class.
bake command Example