Skip to content

add .gitattributes file #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markstory merged 4 commits into from
Feb 12, 2015
Merged

add .gitattributes file #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9048796
add a gitattributes to the repo
antograssiot Feb 11, 2015
05ea35a
add git files to Plugin template
antograssiot Feb 11, 2015
7338479
add indentation definition for yml files
antograssiot Feb 11, 2015
7b7183d
add missing final new line
antograssiot Feb 11, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,7 @@ indent_style = space
indent_size = 4
insert_final_newline = true
trim_trailing_whitespace = true

[*.yml]
indent_style = space
indent_size = 2
Copy link
Copy Markdown
Contributor

@jadb jadb Feb 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for repeating the indent_style?

Also, why not using something like [*.{json,yml}] since I believe it applies to both?

Copy link
Copy Markdown
Member

@dereuromark dereuromark Feb 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jadb only .yml require 2 space. Json is 4 space as normal.

Copy link
Copy Markdown
Contributor Author

@antograssiot antograssiot Feb 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

composer.json fo example have 4 spaces I think...

Copy link
Copy Markdown
Contributor

@jadb jadb Feb 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see 2 spaces being used almost everywhere for json:

https://docs.npmjs.com/misc/coding-style

For example, bower.json is 2 spaces as well.

I noticed now composer init creates it with 4 spaces, not sure why though.

Copy link
Copy Markdown
Member

@ADmad ADmad Feb 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jadb PHP's json_encode() with pretty print option indents using 4 spaces.

4 changes: 4 additions & 0 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# Define the line ending behavior of the different file extensions
# Set default behaviour, in case users don't have core.autocrlf set.
* text=auto
* text eol=lf
4 changes: 4 additions & 0 deletions src/Template/Bake/Plugin/.gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# Define the line ending behavior of the different file extensions
# Set default behaviour, in case users don't have core.autocrlf set.
* text=auto
* text eol=lf
3 changes: 3 additions & 0 deletions src/Template/Bake/Plugin/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
/composer.lock
/phpunit.xml
/vendor