CI: Use noble image for QA tests#641
Merged
3v1n0 merged 11 commits intocanonical:mainfrom Dec 3, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #641 +/- ##
==========================================
- Coverage 83.28% 83.26% -0.03%
==========================================
Files 80 82 +2
Lines 8617 8653 +36
Branches 75 74 -1
==========================================
+ Hits 7177 7205 +28
- Misses 1112 1120 +8
Partials 328 328 ☔ View full report in Codecov by Sentry. |
3v1n0
force-pushed
the
ci-noble
branch
2 times, most recently
from
c579afa to
671525e
Compare
3v1n0
force-pushed
the
ci-noble
branch
7 times, most recently
from
53185eb to
572504e
Compare
adombeck
reviewed
Nov 28, 2024
adombeck
reviewed
Nov 28, 2024
adombeck
reviewed
Nov 28, 2024
Contributor
|
I'm done with the review, everything looks good beside the small thing I remarked in #641 (comment) |
This was referenced Nov 29, 2024
Some tests golden files were not including the whole results, let's fix them by increasing the terminal heights.
In this way we can check for them being in golden files in a reliable way
3v1n0
force-pushed
the
ci-noble
branch
2 times, most recently
from
f2fa8fa to
8b6aad3
Compare
adombeck
reviewed
Dec 2, 2024
adombeck
reviewed
Dec 2, 2024
adombeck
approved these changes
Dec 2, 2024
Add an helper function to check that the golden files contains the final pam runner results strings. In this way we can ensure that the golden files sizes are big enough to hold all the terminal contents.
Keep the values in a more readable way so that's clearer what's the test outcome
We were missing an Enter, so the check was never completed, take the occasion to also add a further check on password mismatch.
That's the ubuntu version we're targetting so far, and so we should care about having it working as expected when doing integration tests in particular.
When running as root or in a schroot we should not care about chrome sandbox used by VHS, so let's ignore it.
These are not needed anymore as the libPAM leaks are fixed in noble
We don't need a docker image anymore now that we're depending on 24.04
3v1n0
added a commit
that referenced
this pull request
Dec 19, 2024
We were relying on sleeping when running integration tests tapes, but this is quite unreliable because: - Depends on the speed of the machine running the tests - Using generous sleeping times implies slower tests (this saves around 10m on CI tests...) So, use `Wait` commands from VHS charmbracelet/vhs#257 to only send input once the UI has the expected contents. Added some `Wait+$Extensions` to make regular expressions easier to maintain, and reducing complexity of the tape files. Fix some potential races that I've found while testing this. Based on #641 UDENG-4964
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That's the ubuntu version we're targetting so far, and so we should care
about having it working as expected when doing integration tests in
particular.
Regenerate the SSH golden files to match post-noble SSH server expectations.
UDENG-5316