Conversation
|
Demo starting at https://canonical-com-619.demos.haus |
Codecov Report
@@ Coverage Diff @@
## candidate #619 +/- ##
=============================================
+ Coverage 48.12% 48.23% +0.10%
=============================================
Files 7 7
Lines 534 537 +3
=============================================
+ Hits 257 259 +2
- Misses 277 278 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Looks great thanks @minkyngkm |
sowasred2012
left a comment
There was a problem hiding this comment.
Nice work! Just one minor change and this will be good to go
|
@minkyngkm still also need to update the |
e5b257d to
896043c
Compare
|
ah sorry, done now! Thanks @sowasred2012 🙌 |
|
@minkyngkm one last thing, I noticed the accordion doesn't have the usual text max-width - can you please apply it? The text inside buttons is far too wide. The variable you need is $text-max-width https://github.com/canonical/vanilla-framework/blob/9a60a7f90c883546b168f48aea88e64a121a7c2e/scss/_settings_spacing.scss#L118 |
94990de to
6b0c4ec
Compare


Done
Build an FAQ page on
/careers/application/faqDemo at https://canonical-com-619.demos.haus/careers/application/faq
QA
./run serveIssue / Card
Fixes #617
Screenshots