Skip to content

Build faq page#619

Merged
minkyngkm merged 6 commits intocanonical:candidatefrom
minkyngkm:build-faq-page
Sep 2, 2022
Merged

Build faq page#619
minkyngkm merged 6 commits intocanonical:candidatefrom
minkyngkm:build-faq-page

Conversation

@minkyngkm
Copy link
Copy Markdown
Contributor

@minkyngkm minkyngkm commented Aug 31, 2022

Done

Build an FAQ page on /careers/application/faq
Demo at https://canonical-com-619.demos.haus/careers/application/faq

QA

  • Check out this feature branch
  • Run the site using the command ./run serve
  • View the site locally in your web browser at: http://0.0.0.0:8002/
  • Run through the following QA steps
  • Compare page against copy doc and design

Issue / Card

Fixes #617

Screenshots

Publisher of Ubuntu | Canonical ()

@webteam-app
Copy link
Copy Markdown

Demo starting at https://canonical-com-619.demos.haus

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 31, 2022

Codecov Report

Merging #619 (6d9e7db) into candidate (fad19b2) will increase coverage by 0.10%.
The diff coverage is 66.66%.

@@              Coverage Diff              @@
##           candidate     #619      +/-   ##
=============================================
+ Coverage      48.12%   48.23%   +0.10%     
=============================================
  Files              7        7              
  Lines            534      537       +3     
=============================================
+ Hits             257      259       +2     
- Misses           277      278       +1     
Flag Coverage Δ
python 48.23% <66.66%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
webapp/application.py 28.07% <66.66%> (+1.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lyubomir-popov
Copy link
Copy Markdown
Contributor

Looks great thanks @minkyngkm

Copy link
Copy Markdown
Contributor

@sowasred2012 sowasred2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Just one minor change and this will be good to go

@sowasred2012
Copy link
Copy Markdown
Contributor

sowasred2012 commented Sep 1, 2022

@minkyngkm still also need to update the h3 tags for each section to h2:

image

@minkyngkm
Copy link
Copy Markdown
Contributor Author

ah sorry, done now! Thanks @sowasred2012 🙌

Copy link
Copy Markdown
Contributor

@sowasred2012 sowasred2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

@lyubomir-popov
Copy link
Copy Markdown
Contributor

@minkyngkm one last thing, I noticed the accordion doesn't have the usual text max-width - can you please apply it? The text inside buttons is far too wide. The variable you need is $text-max-width https://github.com/canonical/vanilla-framework/blob/9a60a7f90c883546b168f48aea88e64a121a7c2e/scss/_settings_spacing.scss#L118

@minkyngkm minkyngkm merged commit 7899e9e into canonical:candidate Sep 2, 2022
@minkyngkm minkyngkm deleted the build-faq-page branch September 2, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[c.c application page] Build FAQ page

4 participants