Skip to content

docs: fix poetry-with description#2053

Merged
lengau merged 1 commit intocanonical:mainfrom
carlcsaposs-canonical:poetry-docs
Dec 19, 2024
Merged

docs: fix poetry-with description#2053
lengau merged 1 commit intocanonical:mainfrom
carlcsaposs-canonical:poetry-docs

Conversation

@carlcsaposs-canonical
Copy link
Contributor

--with is required for optional and non-optional dependencies

see python-poetry/poetry-plugin-export#212 and python-poetry/poetry-plugin-export#299

corresponding PR in canonical/craft-parts#946

Copy link
Collaborator

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@medubelko medubelko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving a non-blocking suggestion.

--with is required for optional and non-optional dependencies

see python-poetry/poetry-plugin-export#212 and python-poetry/poetry-plugin-export#299

corresponding PR in canonical/craft-parts#946
@sergiusens sergiusens changed the title docs: Fix poetry-with description docs: fix poetry-with description Dec 19, 2024
@lengau lengau added this pull request to the merge queue Dec 19, 2024
Merged via the queue into canonical:main with commit 455880a Dec 19, 2024
@carlcsaposs-canonical carlcsaposs-canonical deleted the poetry-docs branch December 20, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants