slugify() in snapd_resource.py breaks checkbox-newparis slot-check tests

[nancyc12]

Bug Description

The new-introduced slugify() function breaks the slot-check tests in checkbox-newparis, including

• kmc-uno-420-gadget/slot-check/serial-port-1
• kmc-uno-420-gadget/slot-check/serial-port-2
• kmc-uno-420-gadget/slot-check/serial-port-3

The interface looks good with snap command.

$ snap interface serial-port --attrs
name:          serial-port
summary:       allows accessing a specific serial port
documentation: https://snapcraft.io/docs/serial-port-interface
plugs:
  - checkbox-newparis
slots:
  - kmc-uno-420-gadget:serial-port-1:
      path:                 /dev/serial-port-1
      usb-interface-number: 0
      usb-product:          24593
      usb-vendor:           1027
  - kmc-uno-420-gadget:serial-port-2:
      path:                 /dev/serial-port-2
      usb-interface-number: 1
      usb-product:          24593
      usb-vendor:           1027
  - kmc-uno-420-gadget:serial-port-3:
      path:                 /dev/serial-port-3
      usb-interface-number: 2
      usb-product:          24593
      usb-vendor:           1027

However, the slugify() turns the attr names to strings like attr_usb-interface-number instead of attr_usb_interface_number which is expected by the test job.

Need someone with a better understanding of the impact to determine whether the fix should be landed on slugify() or checkbox-newparis test job.

Cert-blocker Test Case

• cert-blocker

To Reproduce

1. Launch checkbox-newparis with checkbox-newparis.checkbox-cli run com.canonical.qa.newparis::kmc-uno-420-gadget/slot-check/serial-port-1

Expected Result

Job passed

Actual Result

-----------------[ Check ttysp0 slot provided by gadget snap ]------------------
ID: com.canonical.qa.newparis::kmc-uno-420-gadget/slot-check/serial-port-1
Category: com.canonical.certification::gadget
Job cannot be started because:
 - resource expression "slot.snap == 'kmc-uno-420-gadget' and slot.interface == 'serial-port' and slot.type == 'slot' and slot.name == 'serial-port-1' and int(slot.attr_usb_vendor) == 0x0403 and int(slot.attr_usb_product) == 0x6011 and slot.attr_usb_interface_number == '0' and slot.attr_path == '/dev/serial-port-1'" evaluates to false
Outcome: job failed

Environment

• UC20
• checkbox-newparis 1.3 (28)
• checkbox20 4.3.0-dev71 (2333)

Relevant log output

• Test passed with Checkbox 4.2.0-dev160 (log)
• Test failed with Checkbox 4.3.0-dev71 (log)

Additional context

No response

[syncronize-issues-to-jira]

Thank you for reporting your feedback to us!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CHECKBOX-1762.

This message was autogenerated

[pieqq]

Thanks for the investigation!

I think the best approach is to fix the naming in the newparis provider to use the new naming, and release a new checkbox-newparis snap. I'll work with QA to do that.

[pieqq]

@nancyc12 in the end, the slugify function was fixed to avoid this problem. The next version of Checkbox will include the fix, so you should be able to re-run the tests and it should work.