migrate keys/microphone-mute from pulseaudio to pipewire (BugFix)#1106
Merged
pieqq merged 1 commit intocanonical:mainfrom Mar 29, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1106 +/- ##
===========================================
- Coverage 61.60% 42.80% -18.81%
===========================================
Files 229 351 +122
Lines 23911 38426 +14515
Branches 4104 6528 +2424
===========================================
+ Hits 14731 16449 +1718
- Misses 8604 21318 +12714
- Partials 576 659 +83
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This test case is missed to migrate in the canonical#826
hanhsuan
force-pushed
the
migrate_microphone_mute_from_pulseaudio_to_pipewire
branch
from
146c9b1 to
e8d25bc
Compare
pieqq
approved these changes
Mar 29, 2024
Collaborator
|
LGTM :) |
LiaoU3
pushed a commit
to LiaoU3/checkbox
that referenced
this pull request
Apr 17, 2024
…anonical#1106) migrate from pulseaudio to pipewire This test case is missed to migrate in the canonical#826
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test case is missed to migrate in the #826
Description
This PR is going to make
keys/microphone-mutecould be executed on both environment.Resolved issues
keys/microphone-mutecould be only executed onpulseaudioenvironment only.Documentation
Tests
The command is same with
audio/alsa_record_playback_internal