Skip to content

Reset HID before running the keyboard test (BugFix) #1322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fernando79513 merged 2 commits into from
Jul 24, 2024
Merged

Reset HID before running the keyboard test (BugFix) #1322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d94a5b8
Change: reset HID before running zapper keyboard test
p-gentili Jul 4, 2024
10ea341
Fix: tests
p-gentili Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions providers/base/bin/zapper_keyboard_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ def main(argv):
listener = KeyboardListener(zapper_kbd, events.append)
listener.start()

zapper_run(argv[1], "reset_hid_state")
try:
assert_key_combo(argv[1], events)
assert_type_string(argv[1], events)
Expand Down
12 changes: 10 additions & 2 deletions providers/base/tests/test_zapper_keyboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,13 +127,20 @@ def test_main_no_file_or_permission(self, mock_access, mock_get_dev):
with self.assertRaises(SystemExit):
zapper_keyboard_test.main([1, 2])

@patch("zapper_keyboard_test.zapper_run")
@patch("zapper_keyboard_test.get_zapper_kbd_device")
@patch("zapper_keyboard_test.assert_type_string")
@patch("zapper_keyboard_test.assert_key_combo")
@patch("zapper_keyboard_test.KeyboardListener")
@patch("os.access")
def test_main(
self, mock_access, mock_key, mock_combo, mock_type, mock_get_dev
self,
mock_access,
mock_key,
mock_combo,
mock_type,
mock_get_dev,
mock_run,
):
"""Check main exits with failure if any of the test fails."""

Expand All @@ -143,10 +150,11 @@ def test_main(
mock_combo.side_effect = AssertionError
mock_type.side_effect = None
with self.assertRaises(SystemExit):
zapper_keyboard_test.main([1, 2])
zapper_keyboard_test.main([1, "127.0.0.1"])
mock_key.return_value.start.assert_called_once_with()
mock_key.return_value.stop.assert_called_once_with()
mock_key.return_value.join.assert_called_once_with()
mock_run.assert_called_once_with("127.0.0.1", "reset_hid_state")

mock_combo.side_effect = None
mock_type.side_effect = AssertionError
Expand Down