Convert wan/3gpp-scan test as a automated test (New)#1323
Merged
Conversation
convert 3gpp scan test to automated test
convert 3gpp scan test to automated test
add dependency
…nto auto_3gpp_scan_test
add test job dependency
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1323 +/- ##
==========================================
+ Coverage 44.18% 44.23% +0.05%
==========================================
Files 359 359
Lines 38813 38853 +40
Branches 6581 6584 +3
==========================================
+ Hits 17148 17187 +39
- Misses 21003 21004 +1
Partials 662 662
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
add one more unit test
pieqq
requested changes
Jul 8, 2024
Collaborator
pieqq
left a comment
pieqq
left a comment
There was a problem hiding this comment.
A few comments below, and a change request to use template-ids instead of regex in the test plans.
Co-authored-by: Pierre Equoy <pierre.equoy@canonical.com>
Co-authored-by: Pierre Equoy <pierre.equoy@canonical.com>
re-structure the 3gpp scan test
pieqq
reviewed
Jul 23, 2024
stanley31huang
commented
Jul 23, 2024
fix unit test
pieqq
approved these changes
Jul 23, 2024
Collaborator
pieqq
left a comment
pieqq
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for applying all the changes we discussed here and on Mattermost!
pedro-avalos
pushed a commit
that referenced
this pull request
Jul 29, 2024
- Add a `3gpp-scan` subcommand to the wwan_tests.py script
- Create a new `wwan/3gpp-scan-{manufacturer}-{model}-{hw_id}-auto` template job to automatically scan available GSM connections using the new subcommand
---------
Co-authored-by: Pierre Equoy <pierre.equoy@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Convert wan/3gpp-scan test as a automated test (New)
Resolved issues
OEMQA-4494
Documentation
N/A
Tests
Please refer following submission for the test results (w/ side loaded provider)
https://certification.canonical.com/hardware/202302-31253/submission/379312/ (Updated on 2024/07/08)