Implement desktop environment detector (New)#1343
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1343 +/- ##
==========================================
+ Coverage 44.18% 44.19% +0.01%
==========================================
Files 359 359
Lines 38813 38826 +13
Branches 6581 6585 +4
==========================================
+ Hits 17148 17161 +13
+ Misses 21003 21002 -1
- Partials 662 663 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tomli380576
requested review from
LiaoU3,
baconYao and
seankingyang
and removed request for
LiaoU3 and
seankingyang
baconYao
reviewed
Jul 18, 2024
Contributor
baconYao
left a comment
baconYao
left a comment
There was a problem hiding this comment.
Please see my suggestions.
Hook25
requested changes
Jul 18, 2024
Collaborator
Hook25
left a comment
Hook25
left a comment
There was a problem hiding this comment.
See below, major is the resource one, is this intended?
Hook25
added
the
waiting-for-changes
pedro-avalos
pushed a commit
that referenced
this pull request
Jul 29, 2024
* feat: implement desktop environment detector * fix: remove annotations that are not available in 3.5 * test: add unit tests for has_desktop_env * fix: incorrect patch syntax * test: increase test coverage * fix: apply Patrick's suggestions * fix: accept Massimiliano's suggestions * test: update image_checker tests to reflect changes in source
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a quick utility function to check if the machine has a desktop environment. It works by checking
dpkg's existence and looking for theubuntu-desktopandubuntu-desktop-minialpackages.Resolved issues
Documentation
Tests