Added journalctl lines to the failed_service_check script (BugFix)#1353
Merged
Added journalctl lines to the failed_service_check script (BugFix)#1353
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1353 +/- ##
=======================================
Coverage 44.19% 44.19%
=======================================
Files 359 359
Lines 38826 38826
Branches 6585 6585
=======================================
Hits 17161 17161
Misses 21002 21002
Partials 663 663
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pedro-avalos
pushed a commit
that referenced
this pull request
Jul 29, 2024
…1353) * Added journalctl lines to the failed_service_check script * added the plain flag to not deal with the starting dots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To make test failures easily interpretable, it would be helpful to include some log output from the affected service(s) that were in an unexpected state.
I could refactor this script to python, but I think it's simple enough that It could be left as it was.
Resolved issues
https://warthogs.atlassian.net/browse/CHECKBOX-1247
Documentation
N/A
Tests
The script now includes the last 50 lines of journalctl of the failing service