Skip to content

Use the upstream v1.3.0 version of action build (infra)#1355

Merged
fernando79513 merged 1 commit intomainfrom
upgrade_action_build
Jul 22, 2024
Merged

Use the upstream v1.3.0 version of action build (infra)#1355
fernando79513 merged 1 commit intomainfrom
upgrade_action_build

Conversation

@Hook25
Copy link
Copy Markdown
Collaborator

@Hook25 Hook25 commented Jul 22, 2024

Description

We were using a custom fork of the action build in order to count the results of remote-build and fail the action if too few (or too many?) snaps were created. This is no longer needed as snapcraft 8 fails if any of the remote build fails.

I'm creating this PR because I suspect that the fact that the action-build is so out of date (was forked last year) is a contributing factor in the failure we are currently seeing in the self-hosted builds.

Resolved issues

N/A

Documentation

N/A

Tests

N/A

Copy link
Copy Markdown
Collaborator

@fernando79513 fernando79513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1!

@fernando79513 fernando79513 merged commit e4abb79 into main Jul 22, 2024
@fernando79513 fernando79513 deleted the upgrade_action_build branch July 22, 2024 14:45
pedro-avalos pushed a commit that referenced this pull request Jul 29, 2024
Use the upstream v1.3.0 version of action build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants