removed python3-systemd and using libsystemd instead (BugFix)#1361
Merged
removed python3-systemd and using libsystemd instead (BugFix)#1361
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1361 +/- ##
==========================================
+ Coverage 44.88% 44.95% +0.07%
==========================================
Files 359 360 +1
Lines 38874 38924 +50
Branches 6588 6594 +6
==========================================
+ Hits 17448 17498 +50
Misses 20757 20757
Partials 669 669
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hook25
approved these changes
Jul 24, 2024
Collaborator
Hook25
left a comment
Hook25
left a comment
There was a problem hiding this comment.
+1, tyvm for taking this on
pedro-avalos
pushed a commit
that referenced
this pull request
Jul 29, 2024
* removed python3-systemd and using libsystemd instead * using systemd-python 233 to make it work in checkbox16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The systemd-python package, that was required to use the systemd library in python, required libsystemd-dev to be installed, but we were not installing that library during the build of the snaps.
libsystemd-dev has been added to the build-packages and libsystemd0 to the stage-packages.
The systemd-python version has been updated from 232 to 233 to fix an issue when running the 16.04 snap
Resolved issues
Documentation
Tests
All the snaps have been built remotely successfully.
Tested that the job can be executed in all the snaps.