Skip to content

Add an "Initial Stress Tests" category to distinguish tests that are prepared for stress tests (BugFix)#1368

Merged
zongminl merged 4 commits into
mainfrom
fix-stress-test-catagory
Aug 6, 2024
Merged

Add an "Initial Stress Tests" category to distinguish tests that are prepared for stress tests (BugFix)#1368
zongminl merged 4 commits into
mainfrom
fix-stress-test-catagory

Conversation

@eugene-yujinwu
Copy link
Copy Markdown
Contributor

Fix: Two almost identical 'Stress Tests' lead to some confusion #1319
Add a new category named "Initial Stress Tests" to used for some initial tests of stress tests, such as init-boot-loop-data which used to create a baseline for other tests.

Description

Resolved issues

Two almost identical 'Stress Tests' lead to some confusion #1319

Documentation

Tests

initial-stress-tests-report
initial-stress-tests

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.12%. Comparing base (b3df727) to head (c336387).
Report is 124 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1368   +/-   ##
=======================================
  Coverage   45.12%   45.12%           
=======================================
  Files         366      366           
  Lines       39058    39058           
  Branches     6607     6607           
=======================================
  Hits        17626    17626           
  Misses      20758    20758           
  Partials      674      674           
Flag Coverage Δ
provider-base 18.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@zongminl zongminl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compares to adding an additional category, I'd rather suggest to clean up / remove the duplicated ones and use com.canonical.plainbox::stress for all the stress tests

@Hook25 Hook25 added the waiting-for-changes The review has been completed but the PR is waiting for changes from the author label Jul 29, 2024
@Hook25 Hook25 removed the request for review from pieqq July 29, 2024 09:33
@eugene-yujinwu eugene-yujinwu force-pushed the fix-stress-test-catagory branch from 28acd5e to 903c3f7 Compare July 31, 2024 09:57
@eugene-yujinwu
Copy link
Copy Markdown
Contributor Author

Compares to adding an additional category, I'd rather suggest to clean up / remove the duplicated ones and use com.canonical.plainbox::stress for all the stress tests

@zongminl There are 2 test cases belong to catagory stress-tests: reboot-run-generator and init-boot-loop-data, and I just move them to com.canonical.plainbox::stress.
The results would like this:
Stress-test-new

tomli380576
tomli380576 previously approved these changes Aug 1, 2024
Copy link
Copy Markdown
Contributor

@tomli380576 tomli380576 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay no more duplicate categories :D

Copy link
Copy Markdown
Collaborator

@zongminl zongminl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

…prepared for stress tests (BugFix)

Fix: Two almost identical 'Stress Tests' lead to some confusion #1319
…hat are prepared for stress tests (BugFix)"

This reverts commit fe31a8c.
…s-tests to com.canonical.plainbox::stress per Vic's suggestion
@eugene-yujinwu
Copy link
Copy Markdown
Contributor Author

@zongminl Per your comments, the stress-tests category was removed, and two tests mentioned was change to category com.canonical.plainbox::stress.

Copy link
Copy Markdown
Collaborator

@zongminl zongminl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@zongminl zongminl merged commit 5eb9f2f into main Aug 6, 2024
@zongminl zongminl deleted the fix-stress-test-catagory branch August 6, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-for-changes The review has been completed but the PR is waiting for changes from the author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants