Add manifest entries for special key jobs (BugFix)#1387
Merged
Conversation
Instead of relying on the generic `has_special_keys` manifest entry, create a manifest entry for each of the dedicated keys test present in Checkbox (for instance volume up/down, audio mute, microphone mute, video out, etc.) Use this manifest entries in the related `keys/*` jobs. Remove the unused `has_special_keys` manifest entry. Delete mentions to "manually skip that test" for the `keys/*` jobs, since this is now controlled by a manifest entry.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1387 +/- ##
=======================================
Coverage 45.12% 45.12%
=======================================
Files 366 366
Lines 39058 39058
Branches 6607 6607
=======================================
Hits 17626 17626
Misses 20758 20758
Partials 674 674
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
There are more and more manifest. Is there an easy way to create manifest content for launcher without running the test plan? |
Hook25
approved these changes
Aug 13, 2024
Collaborator
Hook25
left a comment
Hook25
left a comment
There was a problem hiding this comment.
From a checkbox point of view, fantastic, lets get a second opinion from someone from QA
LiaoU3
approved these changes
Sep 3, 2024
Contributor
LiaoU3
left a comment
LiaoU3
left a comment
There was a problem hiding this comment.
It is great to seperate the manifest into several specific items!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Instead of relying on the generic
has_special_keysmanifest entry, create a manifest entry for each of the dedicated keys test present in Checkbox (for instance volume up/down, audio mute, microphone mute, video out, etc.)Use this manifest entries in the related
keys/*jobs.Remove the unused
has_special_keysmanifest entry.Delete mentions to "manually skip that test" for the
keys/*jobs, since this is now controlled by a manifest entry.This looks like this on my device when running the 24.04 desktop full test plan:
Resolved issues
https://warthogs.atlassian.net/browse/CHECKBOX-1321
Documentation
Tests
Tested locally on my DUT by running the 24.04 full test plan, and selecting the jobs in the Hotkey category. The section shown above appears in the System Manifest screen.