EDID test fails at maximum resolution (BugFix)#1393
Merged
Conversation
It's common to have a mismatch between the available modes at EDID level and what the device actually supports. This commit selects the maximum allowed resolution and returns the applied configuration.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1393 +/- ##
==========================================
+ Coverage 45.12% 45.18% +0.05%
==========================================
Files 366 366
Lines 39058 39102 +44
Branches 6607 6609 +2
==========================================
+ Hits 17626 17669 +43
- Misses 20758 20760 +2
+ Partials 674 673 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hook25
previously approved these changes
Aug 7, 2024
Collaborator
Hook25
left a comment
There was a problem hiding this comment.
See if you like the change proposed below but it makes sense
Co-authored-by: Massimiliano <massimiliano.girardi@canonical.com>
d067982 to
8c08ee4
Compare
Hook25
approved these changes
Aug 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Another PR dedicated to the EDID job. It turns out that the new implementation (#1286) shed some light on the other related problem, where older machines could read the maximum allowed resolution.
In case where the HW doesn't support an available mode from the monitor EDID, no preferred mode is available (which makes sense). This PR takes care of such scenario, attempting to configure the monitor with the maximum available resolution.
Resolved issues
Resolves ZAP-678
Documentation
N/A
Tests
Tested on some machines.
Previous behaviour:
Running from source: