pc-sanity: add unit miscellanea/sideload-hook-no-fail (New)#1394
Merged
KaiChuan-Hsieh merged 1 commit intocanonical:mainfrom Aug 22, 2024
Merged
Conversation
This tests 24.04 OEM images which has sideload/hook.sh run during installation and early-OOBE. When a failure in the hook script occurs, it leaves "# FAILED: [command]" in the log. The unit is added into pc-sanity-base and pc-sanity-software-test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This tests 24.04 OEM images which has
sideload/hook.shrun during installation and early-OOBE. When a failure in the hook script occurs, it leaves# FAILED: [command]in the log.Resolved issues
Fixes: SOMERVILLE-245
Tests
The test was done by running the test unit in a normally installed 24.04 OEM system, and the following cases has been tested.
/var/log/installer/sideload-hook.sh.*.log, run the test, passed./var/log/installer/sideload-hook.sh.early-welcome.logand added# FAILED: something failedin the bottom, successfully failed.
/var/log/installer/sideload-hook.sh.*.log, run the test, passed with messagegrep: /var/log/installer/sideload-hook.sh.*.log: No such file or directorysince there's no log to check with.