Skip EDID test if there's no desktop session running (BugFix)#1404
Merged
Skip EDID test if there's no desktop session running (BugFix)#1404
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1404 +/- ##
=======================================
Coverage 45.18% 45.19%
=======================================
Files 366 367 +1
Lines 39102 39118 +16
Branches 6609 6612 +3
=======================================
+ Hits 17669 17680 +11
- Misses 20760 20764 +4
- Partials 673 674 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Zapper EDID job is only checking resources on the Zapper side, not on the DUT. This means the testcase runs on server images as well, failing.
This PR propose a new resource job,
desktop_session, which is used by the EDID job to make sure it runs only on desktop.WARNING: This modifies com.canonical.certification::sru
Resolved issues
N/A
Documentation
N/A
Tests
Tested on https://certification.canonical.com/hardware/202406-34144
Current outcome:
Side-loading the provider: