Skip to content

Add new steps to the interpolation (bugfix)#1410

Merged
Hook25 merged 1 commit intomainfrom
memory_info_more_steps
Aug 9, 2024
Merged

Add new steps to the interpolation (bugfix)#1410
Hook25 merged 1 commit intomainfrom
memory_info_more_steps

Conversation

@Hook25
Copy link
Copy Markdown
Collaborator

@Hook25 Hook25 commented Aug 9, 2024

Description

This job tends to fail on machines with little ram and a GPU. The job already interpolates using the memory to get a reasonable threshold. This adds two new steps.

This comes from this chat for SRU fixups: https://chat.canonical.com/canonical/pl/scp4s13rofbiujter1ifwjrxay

Resolved issues

N/A

Documentation

N/A

Tests

Pre patch:

ubuntu@ubuntu:~/checkbox/providers/base/bin$ ./memory_compare.py 
This script must be run as root.
ubuntu@ubuntu:~/checkbox/providers/base/bin$ sudo !!
sudo ./memory_compare.py 
Results:
	/proc/meminfo reports:	7.11GiB
	lshw reports:	8GiB

FAIL: Meminfo reports 954224640 less than lshw, a difference of 11.11%. Only a variance of 10% in reported memory is allowed.

After patch:

ubuntu@ubuntu:~/checkbox/providers/base/bin$ sudo ./memory_compare.py 
Results:
	/proc/meminfo reports:	7.11GiB
	lshw reports:	8GiB

PASS: Meminfo reports 910.02MiB less than lshw, a difference of 11.11%. This is less than the 15% variance allowed.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 45.18%. Comparing base (a6e44d4) to head (b45127a).
Report is 110 commits behind head on main.

Files with missing lines Patch % Lines
providers/base/bin/memory_compare.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1410      +/-   ##
==========================================
- Coverage   45.18%   45.18%   -0.01%     
==========================================
  Files         366      366              
  Lines       39103    39107       +4     
  Branches     6610     6612       +2     
==========================================
  Hits        17670    17670              
- Misses      20760    20764       +4     
  Partials      673      673              
Flag Coverage Δ
provider-base 18.65% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hook25 Hook25 merged commit dfae162 into main Aug 9, 2024
@Hook25 Hook25 deleted the memory_info_more_steps branch August 9, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants