Add coverage tests for stress_ng_test (New)#1412
Merged
Conversation
This required changing the parameter for `swap_space_ok` from the arguments namespace to just the swap size.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1412 +/- ##
==========================================
+ Coverage 45.18% 45.67% +0.49%
==========================================
Files 366 367 +1
Lines 39107 39118 +11
Branches 6612 6613 +1
==========================================
+ Hits 17670 17867 +197
+ Misses 20764 20577 -187
- Partials 673 674 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Hook25
requested changes
Aug 21, 2024
Collaborator
Hook25
left a comment
There was a problem hiding this comment.
A few suggestions here and there, I'm not sure why but a couple of tests are failing for me locally. Also, please mock range, it is very taxing to run it (and this is ran all the times)
Remove leading `stress_ng_test` where not needed
Moved `os.geteuid` and `shutil.which` mocks to class level.
Hook25
approved these changes
Aug 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds coverage unit tests for
providers/base/bin/stress_ng_test.py. Some minor edits tostress_ng_test.pywere required.Resolved issues
n/a
Documentation
n/a
Tests
This has been tested using
python -m coverage run manage.py test -u.