Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1415 +/- ##
=======================================
Coverage 45.18% 45.19%
=======================================
Files 366 366
Lines 39107 39113 +6
Branches 6612 6613 +1
=======================================
+ Hits 17670 17676 +6
Misses 20764 20764
Partials 673 673
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hook25
previously approved these changes
Aug 12, 2024
Collaborator
Hook25
left a comment
There was a problem hiding this comment.
LGTM, consider printing or dumping to stderr that rest if you want
Hook25
approved these changes
Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In some SRU runs with encountered
dkms statusoutput which included a warning. The dkms source seems to imply this is could be of interest to a user but not an error so therefore handling it in the test without a failuresResolved issues
Documentation
Tests
Extra unit test added and tested on machine dell-latitude7640-c31002