Handle HIDRAW devices that have no parents in the udev stack (BugFix)#1418
Merged
jocave merged 3 commits intoAug 14, 2024
Conversation
The parser "HID devices if nothing else is known to be an input device on the same udev subtree" and hence tries to check the stack of devices seen by udev, but it appears we are now ecountering hidraw devices with no parents
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1418 +/- ##
=======================================
Coverage 45.18% 45.18%
=======================================
Files 366 366
Lines 39107 39107
Branches 6612 6612
=======================================
+ Hits 17670 17671 +1
Misses 20764 20764
+ Partials 673 672 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hook25
approved these changes
Aug 14, 2024
Collaborator
Hook25
left a comment
Hook25
left a comment
There was a problem hiding this comment.
Feel free to take the +1 or commit my suggestion. lgtm
jocave
deleted the
1407-various-detect-jobs-failing-on-certain-devices-due-to-udevadm-parser-problem
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It appears when the code was written it expected HIDRAW devices to always appear in a tree of devices with at least one parent and so at least two items in the stack. It appears we are now encountering devices connected to machines which have no parents.
Link to original merge: fd54837
Resolved issues
Fixes #1407
Documentation
Tests
Included unit test additions from a machine where the bug was reported