Skip to content

Handle no installed dkms modules (BugFix)#1426

Merged
Hook25 merged 2 commits intomainfrom
better-main-patched-tests
Aug 21, 2024
Merged

Handle no installed dkms modules (BugFix)#1426
Hook25 merged 2 commits intomainfrom
better-main-patched-tests

Conversation

@jocave
Copy link
Copy Markdown
Contributor

@jocave jocave commented Aug 19, 2024

Description

The "test_main_*" tests did not actually exercise anything because all calls where mocked and there wasnt any input provided.

The case where there was no dkms modules at all the system was not handled. Add a call_count on test main to ensure this addition wasnt skipping the apt log checking.

Resolved issues

Documentation

Tests

Additional unittests with input from more release

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.20%. Comparing base (7b00249) to head (9c7fb71).
Report is 118 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1426   +/-   ##
=======================================
  Coverage   45.20%   45.20%           
=======================================
  Files         367      367           
  Lines       39125    39129    +4     
  Branches     6614     6615    +1     
=======================================
+ Hits        17688    17690    +2     
- Misses      20764    20765    +1     
- Partials      673      674    +1     
Flag Coverage Δ
provider-sru 97.97% <100.00%> (-2.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@jocave jocave changed the title Handle no installed dkms modules Handle no installed dkms modules (BugFix) Aug 19, 2024
@jocave jocave marked this pull request as ready for review August 19, 2024 18:05
@jocave jocave requested review from Hook25 and fernando79513 August 21, 2024 08:28
Copy link
Copy Markdown
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, tyvm for the new tests as well

@Hook25 Hook25 merged commit 77b84c8 into main Aug 21, 2024
@Hook25 Hook25 deleted the better-main-patched-tests branch August 21, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants