Handle no installed dkms modules (BugFix)#1426
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1426 +/- ##
=======================================
Coverage 45.20% 45.20%
=======================================
Files 367 367
Lines 39125 39129 +4
Branches 6614 6615 +1
=======================================
+ Hits 17688 17690 +2
- Misses 20764 20765 +1
- Partials 673 674 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Hook25
approved these changes
Aug 21, 2024
Collaborator
Hook25
left a comment
There was a problem hiding this comment.
+1, tyvm for the new tests as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The "test_main_*" tests did not actually exercise anything because all calls where mocked and there wasnt any input provided.
The case where there was no dkms modules at all the system was not handled. Add a call_count on test main to ensure this addition wasnt skipping the apt log checking.
Resolved issues
Documentation
Tests
Additional unittests with input from more release