Merged
Conversation
This uses the debian packages to avoid situations where we randomly break metabox when a pip package updates like setuptools right now (also I dont see any advantage to installing straight from pip). This updates to ubuntu latest to have the most updated possible version of every debian package so that we don't encounter weird regressions due to the downgrade This also uses a venv because installing straight to system is a footgun and it doesn't work with the current version of dependencies
pieqq
approved these changes
Aug 21, 2024
Collaborator
pieqq
left a comment
pieqq
left a comment
There was a problem hiding this comment.
+1. Thanks for saving the day! 🧯 🔥
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes two issues with metabox + 1 issue with a recently added test plan in the metabox provider
Root cause of the initial issue: setuptools updated and is now broken due to some incompatibility (I don't really know which) with importlib_metadata
Resolved issues
Fixes: CHECKBOX-1536
Documentation
This adds a few new comments to the workflow to explain why it is the way it is.
Tests
Passing test: https://github.com/canonical/checkbox/actions/runs/10487592300/job/29049421985