Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1454 +/- ##
==========================================
+ Coverage 47.10% 47.11% +0.01%
==========================================
Files 368 368
Lines 39435 39443 +8
Branches 6667 6668 +1
==========================================
+ Hits 18574 18585 +11
+ Misses 20156 20155 -1
+ Partials 705 703 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fernando79513
force-pushed
the
ordering-of-storage-tests
branch
from
bdfe449 to
c777941
Compare
fernando79513
force-pushed
the
ordering-of-storage-tests
branch
from
c777941 to
617432a
Compare
Hook25
approved these changes
Sep 18, 2024
Collaborator
Hook25
left a comment
Hook25
left a comment
There was a problem hiding this comment.
This is very nice, better descriptions, better structure, less jobs, less sibilings, usage of the after-suspend flag, solves the issue... Well done! +1
Contributor
|
Verify Pass on Boashan G1200 snap info Submission: https://certification.canonical.com/hardware/202307-31864/submission/398134/test-results/?term=zapper-usb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WARNING: This modifies com.canonical.certification::sru-server
Description
As commented in #910, if the USB manual tests fail, when user reruns the failed jobs, the execution order will lose the original sequence.
This PR aims to solve this issue by merging the 3 storage tests insertion/storage/removal into one unique test that performs the three actions.
Here you can find the conversation in Mattermost
Resolved issues
#91
https://warthogs.atlassian.net/browse/CHECKBOX-1497
Documentation
N/A
Tests
Storage tests (22.04 laptop)
submission_2024-09-16T10.44.35.228920.zip
Zapper USB tests
submission_2024-09-16T11.58.24.029262.zip