Include image information in Checkbox submission (New)#1460
Conversation
Inspired by pc-sanity get-image-url.sh
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1460 +/- ##
=======================================
Coverage 46.13% 46.13%
=======================================
Files 367 367
Lines 39206 39210 +4
Branches 6633 6633
=======================================
+ Hits 18088 18091 +3
- Misses 20421 20422 +1
Partials 697 697
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pieqq
left a comment
There was a problem hiding this comment.
Looks good to me!
Does it mean we can remove the get-image-url.sh script and associated job in the sanity provider?
|
I wouldn't remove it for now, as that will disrupt them and this is intended to collect the information and not give immediate feedback to the user (as in, it wont fail publicly in the log, prompting you to maybe update the string and rerun it), so it may not fit their purpose |
This creates a new system_information collector that collects the URL if possible (namely, if ubuntu-report is installed on the machine and if the DCD string is there and valid). This safely fails in unexpected situations, reporting the error. This also stores (in the stderr of the collector) the full report non-destructively, so in any situation we can go back and re-interpret the data. This is inspired by PC Sanity provider's `get-image-url.sh` script.
Description
New job in pc-saity called com.canonical.certification::info/image-url calls bash script called get-image-url.sh. Probably needs some work to port it to the system_information section of the submission file.
This creates a new system_information collector that collects the URL if possible (namely, if ubuntu-report is installed on the machine and if the dcd string is there and valid). This safely fails in unexpected situations reporting the error. This also stores (in the stderr of the collector) the full report non-destructively, so in any situation we can go back and re-interpret the data
Resolved issues
Fixes: https://warthogs.atlassian.net/browse/CHECKBOX-1541
Documentation
N/A
Tests
This also adds appropriate unit tests