Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1489 +/- ##
==========================================
+ Coverage 45.87% 45.88% +0.01%
==========================================
Files 367 367
Lines 39156 39167 +11
Branches 6622 6628 +6
==========================================
+ Hits 17961 17970 +9
- Misses 20504 20505 +1
- Partials 691 692 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pieqq
previously approved these changes
Sep 23, 2024
Collaborator
pieqq
left a comment
There was a problem hiding this comment.
Thanks for the comments in _get_relevant_manifest_units, otherwise that would be pretty complicated to parse!
I've played with it a little bit and it seems to do what it's advertised for.
I only have one inline comment about the fact that now every job has a template_id attribute, even if it's null.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We need a way to programmatically fetch the list of manifest entries needed to run a test plan. This makes it easier to automatically verify manifests in CI, track changes to testplans manifest entries and more. This adds manifest units to the
expandcommand filtering out those that aren't used in the testplan.Resolved issues
Fixes: https://warthogs.atlassian.net/browse/CHECKBOX-1555
Documentation
This adds plenty comments to the expander.
Tests
WIP