Migrate checkbox-dss-validation to checkbox/contrib (New)#1524
Merged
Conversation
cecf1cc to
a60eb52
Compare
Contributor
Author
|
The Workflow validation workflow is failing because the Created issue #1525 for it. |
pieqq
previously requested changes
Oct 2, 2024
Collaborator
pieqq
left a comment
There was a problem hiding this comment.
Just a quick glance at this, I noticed a few things that should be changed in the provider's manage.py file.
contrib/checkbox-dss-validation/checkbox-provider-dss/manage.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-dss-validation/checkbox-provider-dss/manage.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-dss-validation/checkbox-provider-dss/manage.py
Outdated
Show resolved
Hide resolved
Contributor
Author
|
New run in Testflinger after making requested changes: 4d890e0f-327c-4639-9aba-6334b413c777 |
* the original source repo was at commit bc07d01: <https://github.com/canonical/checkbox-dss-validation/tree/bc07d017e32706fd1578c0982c50d997ed8d47ac>. * the following directories or their contents were NOT copied - .github - checkbox-provider-dss/bin : because it had binary files, not used anywhere * no other modifications were made to the copied files
This reverts commit 0f42780. Updating the namespace starts to fail validation with errors like: error: units/jobs.pxu:4: job 'intel_gpu/host_gpu_avail', field 'requires', unit 'com.canonical.contrib::executable' is not available
f943f74 to
58860ba
Compare
As described in the readme, providers in the contrib area must have a namespace that includes the word contrib. Switching from `com.canonical.certification` to `com.canonical.contrib`. This means that jobs and test plans from the base providers need to be prefixed with the `com.canonical.certification` namespace.
Contributor
Author
|
Tests pass in Testflinger after changing namespace. |
Hook25
approved these changes
Oct 7, 2024
Dismissing and approving as requested on MM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Copied the most relevant files from the original repo at commit
bc07d01and placed them in the newly created directory atcontrib/checkbox-dss-validation. Solutions QA team has been added to.github/CODEOWNERSfor the relevant directories and GitHub workflows.Files under
checkbox-provider-dss/binin the original repo were not copied because it had a binary file, and none of the files were being used in the jobs anyway.The only relevant GitHub workflow for regression testing of DSS was also copied. The relevant workflow has to be run in Testflinger, and its definition has been added to
.github/workflows, while the relevant Testflinger job's definition has been copied tocontrib/checkbox-dss-validation/testflinger/job-def.yamldirectory. These files have changes from the original so that they point to the relevant directory in this repository instead of the original one.Nevertheless, I have not made any changes to this repository's settings to enable running the workflow with Testflinger. I did not see the workflow being available to run in the GitHub Actions tab for this repo to check if the workflows will run or not.
Similarly, minimal updates (from the original) have been made to the README of the provider to now point to this repository instead of the original one in instructions.
An attempt was made to change the namespace of the provider from
com.canonical.certificationtocom.canonical.contribas suggested incontrib's README, but this lead to errors during validation of the provider.Details of the validation errors on changing namespace to `contrib`
Resolved issues
Documentation
No updates to Checkbox documentation.
Tests
Testing was done using the following Testflinger job definition, with a successful run 7014854f-82c9-45cc-8374-b9c91f8f2046: